PopoverEducational: fix zIndex bug + add example #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertCarreras
commented
Mar 20, 2024
| @@ -170,35 +170,34 @@ export default function PopoverEducational({ | |||
|
|
|||
| if (!isInExperiment) | |||
| return ( | |||
| <Box zIndex={zIndex} position={zIndex ? 'relative' : undefined}> | |||
There was a problem hiding this comment.
Moving zIndex from this Box to Contents component with position absolute.
<Box zIndex={zIndex} position={zIndex ? 'relative' : undefined}>
AlbertCarreras
changed the title
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
willsmanley
approved these changes
Mar 20, 2024
AlbertCarreras
force-pushed
the
PopEduIndex
branch
from
a96d159
to
c2d07a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PopoverEducational: fix zIndex bug + add example
Zindex was not properly working. Zindex was not being applied to absolute positioned Contents component. Removed unnecessary Box.
BEFORE
AFTER
