Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Try to add visual-test results to CI #3419

Closed
wants to merge 39 commits into from

Conversation

rlingineni
Copy link
Contributor

Pull Request Instructions

Trying to add Visual-test results to CI

Pull Request Template

Summary

What changed?

At a high level, what changes does this PR introduce?

Why?

What is the purpose of this PR? Please include the context around these changes for Future Us. In addition to what is changing, we need to know why these changes are needed. Imagine someone is looking at these changes a year from now and needs to know why they were made.

Links

  • Jira
  • [TDD](link to Paper doc)
  • [Figma](link to Figma file)

Checklist

  • Added unit and Flow Tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit b903a9f
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/65c68effa5db81000843df33
😎 Deploy Preview https://deploy-preview-3419--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit 2b85ee5
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/65ce4af1b2cc710008bef95b
😎 Deploy Preview https://deploy-preview-3419--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rlingineni
Copy link
Contributor Author

Hi from the comments API

@rlingineni
Copy link
Contributor Author

Visual test output will be shown!!

3 similar comments
@rlingineni
Copy link
Contributor Author

Visual test output will be shown!!

@rlingineni
Copy link
Contributor Author

Visual test output will be shown!!

@rlingineni
Copy link
Contributor Author

Visual test output will be shown!!

@rlingineni
Copy link
Contributor Author

Running 160 tests
This is an automated visual test report.

Failed Visual Snapshots ❌

These test failures may or may not be related to your changes. These are not blocking.
0 failed visual tests:
To see the failed tests, run the following command:
yarn run playwright:visual-test test --ui"
To update failed tests, run
yarn run playwright:visual-test --update-snapshots"
Total Test Run Time: 3:18

@rlingineni
Copy link
Contributor Author

This is an automated test report
Running 160 tests

Failed Visual Snapshots ❌


Note: These test failures may or may not be related to your changes. They are not blocking.

47 failed visual tests:

  • Accordion
  • ActivationCard
  • BannerCallout
  • BannerOverlay
  • BannerSlim
  • BannerUpsell
  • Checkbox
  • Column
  • ComboBox
  • Container
  • Datapoint
  • DateField
  • DatePicker
  • DateRange
  • Dropdown
  • Fieldset
  • Flex
  • Heading
  • HelpButton
  • Label
  • Link
  • List
  • Modal-dark
  • Modal
  • ModalAlert
  • Mobile
  • NumberField
  • PageHeader
  • Pog
  • RadioGroup
  • SearchField
  • SegmentedControl-dark
  • SegmentedControl
  • SelectList
  • Status
  • Switch
  • Table
  • TableOfContents
  • Tabs-dark
  • Tabs
  • Text
  • TextArea
  • TextField
  • TileData
  • Toast
  • WashAnimated
  • ZIndex
    To see the failed tests, run the following command locally:
    yarn run playwright:visual-test test --ui

To update failed tests, run
yarn run playwright:visual-test --update-snapshots

Total Test Run Time: 3m 19s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants