PDI-1813: Export block HCL generation for PingFederate #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update makefile and github workflows to support PingFederate testing. - Update many variables and functions to differentiate PF services versus PingOne services. - Update platform export subcommand to support PingFederate export, with Basic Auth, Access Token Auth, and Client Credentials Auth supported. Configure the command flags to be mutually exclusive per auth method. - Update many test cases and testing utilities to test this new functionality. - Add PingFederate connector and one resource AuthenticationApiApplication to test new export functionality. - Add server-profiles folder to hold PingFederate configuration used when starting test PingFederate containers.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Update Option Objects variable names to contain the service name to distinguish between PingOne options and PingFederate Options. - Update Cobra Subcommand `platform export` to support the new export service PingFederate. Add additional examples for PingFederate export parameters. Break out cobra flag configuration by service, and add PingFederate flags. Mark each PingFederate Auth method as mutually exclusive for the user to avoid authentication confusion. - Update cobra root command root.go to fail if user provided config file does not exist. - Add profile config enum type ENUM_STRING_SLICE for PF scopes and PF pem files. Support these slices in set_internal.go and validate.go. - Update export_internal.go to initialize both PingOne go client and PingFederate go client when needed. Update getExportableConnectors to use instance variables depending on the service connector specified. - Break out SDKClientInfo into PingOneClientInfo and PingFederateClientInfo for different services. - Create pingfederate_connector.go to export PF API resources. - Add first PF resource for export, pingfederate_authentication_api_application.go - Add server-profiles directory to hold PingFederate server-profile for container starting and testing.
henryrecker-pingidentity
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distinguish between PingOne options and PingFederate Options.
platform exportto support the new exportservice PingFederate. Add additional examples for PingFederate export
parameters. Break out cobra flag configuration by service, and add
PingFederate flags. Mark each PingFederate Auth method as mutually
exclusive for the user to avoid authentication confusion.
does not exist.
PF pem files. Support these slices in set_internal.go and validate.go.
PingFederate go client when needed. Update getExportableConnectors
to use instance variables depending on the service connector specified.
for different services.
container starting and testing.