Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDI-2104: UAT Fixes for Various Bugs #31

Merged
merged 12 commits into from
Nov 13, 2024
Merged

Conversation

erikostien-pingidentity
Copy link
Contributor

  • Save access token to user-specified profile if exists
  • Make set and unset output in one json object. Add spacing
  • Make output-format=json always output the message and avoid nil dereference
  • Make both parent key validation and key validation use EqualFold for case-insensitive matching
  • Default viper keys on profile add creation
  • Disable TestNotificationTemplateContentExport for Issue When using platform export, some configuration resources are not generated when there are many results #29
  • Remove --profile-name flag from get/set/unset config commands
  • Update Dependencies

Copy link
Collaborator

@samir-gandhi samir-gandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through the code, but I did test each of the fixes manually in the cli and the fixes look good!

@erikostien-pingidentity erikostien-pingidentity merged commit 2452c10 into main Nov 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants