Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add minimal-tanstack-start example #989
chore: add minimal-tanstack-start example #989
Changes from 7 commits
0108a3a
77b6cf9
f4c79a6
e89f267
d2c0f01
5914813
caa533c
7d72d47
d802055
ad5b14d
a9bae02
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review request logging and uncomment header check if necessary
The middleware is logging the entire request object, which might include sensitive information. Consider logging only necessary information or sanitizing the log output.
There's a commented-out header check. If this check is important for security or functionality, it should be uncommented and implemented properly.
To address these concerns:
If the header check is not needed, consider removing the commented code to improve readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refine upload completion logging and remove development comments
The
onUploadComplete
callback is logging the entire file object, which might contain sensitive information. Consider logging only necessary, non-sensitive details.There are type assertion comments (^?) which appear to be leftover from development. These should be removed in the production code.
To address these points:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kinda hate this but it works... not sure where else we can import uploadRouter without leaking it to client bundle.