Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow async onBeforeUploadBegin callback #529

Merged
merged 6 commits into from
Dec 26, 2023
Merged

feat: allow async onBeforeUploadBegin callback #529

merged 6 commits into from
Dec 26, 2023

Conversation

ibrahimyaacob92
Copy link
Contributor

  • PR is created to counter the issue faced when trying to validate the uploaded files with async function

image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 25, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 10a013e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@uploadthing/react Minor
@uploadthing/solid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 7:48pm

@markflorkowski markflorkowski added the release canary Trigger a canary release to npm label Dec 25, 2023
@juliusmarminge juliusmarminge added release canary Trigger a canary release to npm and removed release canary Trigger a canary release to npm labels Dec 26, 2023
juliusmarminge
juliusmarminge requested changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just formatting left, i dont have my laptop at hand so cant do it myself

@juliusmarminge juliusmarminge merged commit 3b7e901 into pingdotgg:main Dec 26, 2023
10 checks passed
@t3dotgg t3dotgg mentioned this pull request Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

Assignees
No one assigned
Labels
@uploadthing/react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibrahimyaacob92 @juliusmarminge @markflorkowski