Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: h3 adapter #358

Merged
merged 31 commits into from
Sep 29, 2023
Merged

feat: h3 adapter #358

merged 31 commits into from
Sep 29, 2023

Conversation

juliusmarminge
Copy link
Collaborator

@juliusmarminge juliusmarminge commented Sep 16, 2023 •
edited
Loading

Generic adapter that can be used for Nitro (new SolidStart, Nuxt etc) and other servers using H3

Bored of setting up react vite frontend. Example works with any of the vite clients from the express or fastify examples. We are probably good with just a single one that connects to either of the backend adapter examples

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 63d83a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 7:53pm

@juliusmarminge juliusmarminge marked this pull request as ready for review September 16, 2023 09:29
This was referenced Sep 16, 2023
Merged
Open
@juliusmarminge @danielroe
🤦‍♂️
38f8a15 
Co-authored-by: Daniel Roe <[email protected]>
juliusmarminge
juliusmarminge commented Sep 29, 2023
View reviewed changes
packages/uploadthing/src/internal/types.ts
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder for myself to look over these types, doesn't make sense having to add an any generic in a bunch of places like this...

@juliusmarminge juliusmarminge merged commit 3cb4d8b into main Sep 29, 2023
5 checks passed
@juliusmarminge juliusmarminge deleted the h3-adapter branch November 9, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

@markflorkowski markflorkowski markflorkowski approved these changes

Assignees
No one assigned
Labels
📚 documentation examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusmarminge @markflorkowski @danielroe