Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: disable coverage upload #5758

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

the coverage files merge tool can't work in Golang v1.21 now, so we choose to disable it in release-1.5

✗ make gocovmerge
GOBIN=/home/ubuntu/go/src/github.com/pingcap/tidb-operator/bin/ GOOS=linux GOARCH=arm64 go install github.com/zhouqiang-cl/gocovmerge@latest
go: downloading github.com/zhouqiang-cl/gocovmerge v0.0.0-20190125174600-5256314471af
go: finding module for package golang.org/x/tools/cover
go: downloading golang.org/x/tools v0.26.0
go: toolchain upgrade needed to resolve golang.org/x/tools/cover
go: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.3)
make: *** [Makefile:180: gocovmerge] Error 1

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge October 8, 2024 09:57
@ti-chi-bot ti-chi-bot bot added the size/S label Oct 8, 2024
@csuzhangxc csuzhangxc merged commit 182f48e into release-1.5 Oct 8, 2024
5 of 6 checks passed
@csuzhangxc csuzhangxc deleted the csuzhangxc/disable-cov branch October 8, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant