Validate resources.request.storage
for each item in spec.tiflash.storageClaims
#4635
+72
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR solves the problem that assigning empty objects under
storageClaims
of tiflash can bypass the validation of the operator.We found that when we specified tiflash spec with some empty objects under
storageClaims
, we got rejection from the events saying thatstorage
is a required field. However, we did not get error messages or alerts from the operator indicating thatstorage
is required.Additionally, from the source code of TiDB operator, we discovered that assigning empty objects under
storageClaims
can bypass the operator's validation code. For details, please refer to the issue we submitted: #4613What is changed and how does it work?
We believed it is necessary to check whether
storage
is set when specifyingstorageClaims
for tiflash. We added a sanity check in the functionvalidateTiFlashSpec
to see whetherstorage
exists in the resource requests.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.