Add resolution parameter to InkyMockImpression.__init__
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits simpler setting of the size of the Inky Impression being mocked. For example, this allows: ``` python display = InkyMockImpression((800, 480)) ``` which will ensure that the buffer size gets set up correctly. Fixes pimoroni#168.
|
Oof, may need a rebase now I've merged #167 |
Gadgetoid
added a commit
that referenced
this pull request
Nov 20, 2023
Copied from #169 Co-authored-by: Phil Howard <[email protected]>
|
I have added this as a commit onto my WIP repackaged branch here: fe70476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits simpler setting of the size of the Inky Impression being mocked.
For example, this allows:
which will ensure that the buffer size gets set up correctly.
Fixes #168.