Skip to content

Commit

Permalink
Remove hardcoded db names in dumps (#590)
Browse files Browse the repository at this point in the history
* Remove hardcoded db names

* Fix test
  • Loading branch information
blankse authored Jul 4, 2024
1 parent 13681c9 commit ed71d37
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pimcore-demo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ jobs:
cd sample-project/
docker-compose exec -T -- php composer remove pimcore/platform-version --no-update
docker-compose exec -T -- php composer require pimcore/pimcore:"${UPGRADE_VERSION}"
docker-compose exec -T -- php composer require pimcore/pimcore:"${UPGRADE_VERSION}" --with-all-dependencies
# Run pimcore migration.
docker-compose exec -T -- php ./bin/console doctrine:migrations:migrate
Expand Down
6 changes: 3 additions & 3 deletions dump/data-0-bootstrap.sql
Original file line number Diff line number Diff line change
Expand Up @@ -3258,7 +3258,7 @@ CREATE TABLE `generic_execution_engine_job_run` (
totalElements int unsigned NOT NULL,
processedElementsForStep int unsigned NOT NULL,
CONSTRAINT fk_generic_job_execution_owner_users
FOREIGN KEY (ownerId) REFERENCES pimcore.users (id)
FOREIGN KEY (ownerId) REFERENCES users (id)
ON DELETE SET NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;

Expand All @@ -3269,6 +3269,6 @@ CREATE TABLE `generic_execution_engine_error_log` (
elementId int unsigned NULL,
errorMessage text NULL,
CONSTRAINT fk_generic_job_execution_log_jobs
FOREIGN KEY (jobRunId) REFERENCES pimcore.generic_execution_engine_job_run (id)
FOREIGN KEY (jobRunId) REFERENCES generic_execution_engine_job_run (id)
ON DELETE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;

0 comments on commit ed71d37

Please sign in to comment.