Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Error using "As input quantity value" mapper #345

Merged
merged 12 commits into from
Jul 31, 2023
Merged

[Bug]: Error using "As input quantity value" mapper #345

merged 12 commits into from
Jul 31, 2023

Conversation

robertSt7
Copy link
Contributor

resolves #340

@robertSt7 robertSt7 added the Bug label Jul 25, 2023
@robertSt7 robertSt7 added this to the 1.8.2 milestone Jul 25, 2023
@robertSt7 robertSt7 linked an issue Jul 25, 2023 that may be closed by this pull request
[Bug]: Error using "As input quantity value" mapper #340
Closed
@kingjia90 kingjia90 self-assigned this Jul 26, 2023
@kingjia90 kingjia90 assigned robertSt7 and unassigned kingjia90 Jul 26, 2023
@kingjia90
Copy link
Contributor

kingjia90 commented Jul 26, 2023 •
edited
Loading

not sure about the changes 🤔 but works and looks more in line with latest implementations.
In the core, there are Model/QuantityValue and Model/InputQuantityValue, that both extend AbstractQuantityValue, while here (before PR) in the importer Operator/InputQuantityValue extends Operator/QuantityValue, as if it's an alias/shortcut to directly pass the unit as string.
It feels like some refactoring in the core (AbstractQuantityValue) didn't got the follow-up in this bundle, maybe due BC

@robertSt7 robertSt7 merged commit cac31ed into 1.8 Jul 31, 2023
9 checks passed
@robertSt7 robertSt7 deleted the 340-bug-error-using-as-input-quantity-value-mapper branch July 31, 2023 07:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 left review comments

Assignees

@kingjia90 kingjia90

@robertSt7 robertSt7

Labels
Bug
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.

[Bug]: Error using "As input quantity value" mapper
2 participants
@robertSt7 @kingjia90