Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: exclude_classes not working correctly #269

Conversation

kevinloeber-twocream
Copy link
Contributor

Expected behavior: Pimcore should not try to request the index of exlcuded classes

Actual behavor: If you try to delete an object of an excluded class, an error occured that the index for this class does not exists

Steps to reproduce: Exclude a class and try to delete the object

@skoch-twocream
Copy link

Thanks!

@mattamon mattamon self-assigned this Aug 26, 2024
@mattamon mattamon added the Bug label Aug 26, 2024
@mattamon
Copy link
Contributor

Hey @kevinloeber-twocream thank you for your contribution!

I would consider this a bug no? Should we rebase it to 6.0?

@mattamon mattamon added this to the 6.0.3 milestone Aug 26, 2024
@kevinloeber-twocream
Copy link
Contributor Author

Hello @mattamon,

Yes, this is a bug. You can rebase to 6.0 so that continue working with it immediately without errors.

@mattamon mattamon changed the base branch from 6.x to 6.0 August 27, 2024 08:34
@mattamon mattamon changed the base branch from 6.0 to 6.x August 27, 2024 08:34
@mattamon
Copy link
Contributor

Hello @mattamon,

Yes, this is a bug. You can rebase to 6.0 so that continue working with it immediately without errors.

I tried to rebase it now, but unfortunately it is not that easy. Since 6.x has already some commits in it, if I rebase, those commits would also be in 6.0.
So automatic rebasing does not work in this case.
Can you please do a proper rebase. You also can open up a new PR where you start with 6.0 to branch off.

@kevinloeber-twocream
Copy link
Contributor Author

Okay, I'll close the PR and open a new one

@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
@kevinloeber-twocream kevinloeber-twocream deleted the bug-exclude-classes-not-working-correctly branch August 27, 2024 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants