Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Xlsx export issue #262

Merged
merged 5 commits into from
Aug 29, 2024
Merged

[Bug]: Xlsx export issue #262

merged 5 commits into from
Aug 29, 2024

Conversation

jtwogw
Copy link
Contributor

@jtwogw jtwogw commented Apr 22, 2024

Resolves #256

Copy link

github-actions bot commented Apr 22, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jtwogw
Copy link
Contributor Author

jtwogw commented Apr 22, 2024

I have read the CLA Document and I hereby sign the CLA

@mcop1 mcop1 changed the title 256# tmp fix for xlsx export https://github.com/pimcore/advanced-obje… [Bug]: Xlsx export issue Jun 21, 2024
@mcop1 mcop1 added this to the 6.0.2 milestone Jun 21, 2024
Copy link
Contributor

@mcop1 mcop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtwogw Thanks for providing a pull request and sorry for the late answer. Could you please have a look at my suggestions. Basically I just removed the comments and tried to think of a better name for method. Feel free to add the suggestions or maybe think of an even better name for the method.
Thanks again!

src/Resources/public/js/searchConfig/resultPanel.js Outdated Show resolved Hide resolved
src/Resources/public/js/searchConfig/resultPanel.js Outdated Show resolved Hide resolved
src/Resources/public/js/searchConfig/resultPanel.js Outdated Show resolved Hide resolved
@markus-moser markus-moser modified the milestones: 6.0.2, 6.0.3 Jul 16, 2024
@mcop1 mcop1 self-assigned this Jul 26, 2024
@mcop1 mcop1 merged commit 709332d into pimcore:6.x Aug 29, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@mcop1 mcop1 added the Bug label Aug 29, 2024
@mcop1 mcop1 modified the milestones: 6.0.3, 6.1.0 Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Xlsx export issue with ES8 and Advanced Object Search 5
4 participants