Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Object editing] Relational fields' grid: remember column widths #664

Merged

Conversation

BlackbitDevs
Copy link
Contributor

When there are a lot of columns to be displayed for (advanced) many-to-many (object) relation fields, the available space may not suffice for some users while it does nor others, depending on their monitor size. Currently for the configured "visible fields" the widths of the fields gets distributed evenly:


And for meta fields of advanced relations you can only set the width globally for all users.

Of course, the user can adjust column widths when editing an object but after reloading the object or opening another object of the same class, he has to do this again and again.

With this PR the column widths get saved to the browser's local storage and restored when loading an object of the same class and layout.

@BlackbitDevs BlackbitDevs marked this pull request as ready for review August 22, 2024 13:27
@mattamon
Copy link
Contributor

Hey @BlackbitDevs could you please resolve the conflict.

@BlackbitDevs
Copy link
Contributor Author

Conflict resolved.

Copy link

sonarcloud bot commented Sep 2, 2024

@mattamon mattamon self-assigned this Sep 2, 2024
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and is a nice addition!

Thank you for the contribution!

@mattamon mattamon added this to the 1.6.0 milestone Sep 3, 2024
@mattamon mattamon merged commit 80498ed into pimcore:1.x Sep 3, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants