-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show tree search if paging is not necessary #656
Show tree search if paging is not necessary #656
Conversation
so search is now shown all the time for every folder? |
Yes. Of course we can also add a threshold so that the search only gets shown if there are more than X items. |
I think a threshold would be nice yes. Could use the default limit again like 30? |
Have added threshold: only if parent element has >= 30 child items, the search does get shown. |
Perfect thank you! |
Added changelog. |
…without-paging # Conflicts: # CHANGELOG.md
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for your effort!
@fashxp WDYT? The 30 element search limit was added.
If you set
and an element has less than 1000 children, the paging toolbar does not get displayed. The downside is that also the search does not get displayed then.
This PR changes this: Even if all items fit on the current page, there is still the search shown:
The behaviour if
tree_paging_limit
< total number of children does not get changed.