[Improvement] - Dynamic Option Provider #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect option provider
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
procnet0
changed the title
|
recheck |
|
@procnet0 Could you please replace |
@robertSt7 could you have a look again please. I changed it now to |
robertSt7
reviewed
Aug 30, 2024
|
|
||
| let fields = this.currentElements[j].fields; | ||
| for (let fieldName in fields) { | ||
| if (this.currentElements[j].fields.hasOwnProperty(fieldName)) { |
There was a problem hiding this comment.
@procnet0 Sorry, I don't get why we need this check, because for me this.currentElemenst[j].fields is the same as fields and you iterate over fields. So the prop fieldName should always be in fields right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add context for Blocks/bricks/fieldcollection for select and multiselect option provider.