Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] - Dynamic Option Provider #361

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

procnet0
Copy link

Add context for Blocks/bricks/fieldcollection for select and multiselect option provider.

Copy link

github-actions bot commented Nov 28, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@procnet0
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@procnet0
Copy link
Author

recheck

@procnet0 procnet0 changed the title Improvement - Dynamic Option Provider [Improvement] - Dynamic Option Provider Nov 28, 2023
@procnet0
Copy link
Author

recheck

@procnet0 procnet0 marked this pull request as draft December 6, 2023 09:36
@procnet0 procnet0 marked this pull request as ready for review December 6, 2023 09:37
@robertSt7 robertSt7 closed this Jan 31, 2024
@robertSt7 robertSt7 reopened this Jan 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@robertSt7
Copy link
Contributor

@procnet0 Could you please replace var with let and const. Thank you

@mattamon
Copy link
Contributor

@procnet0 Could you please replace var with let and const. Thank you

@robertSt7 could you have a look again please. I changed it now to let

@pimcore pimcore unlocked this conversation Aug 29, 2024

let fields = this.currentElements[j].fields;
for (let fieldName in fields) {
if (this.currentElements[j].fields.hasOwnProperty(fieldName)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@procnet0 Sorry, I don't get why we need this check, because for me this.currentElemenst[j].fields is the same as fields and you iterate over fields. So the prop fieldName should always be in fields right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants