Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard #118

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Standard #118

merged 2 commits into from
Sep 1, 2024

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Sep 1, 2024

This is the third project I have touched which has a broken eslint config in the express project. I know we had a long discussion about this in slack, but I am making an executive decision to merge this here. If someone wants to come back and replace this with something else I am fine with that, but we need to make progress and dealing with broken old lint configs is not how I am going to spend my time right now.

Also note I added the .git-blame-ignore-revs file where we can track bulk changes like this to preserve blame.

https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

git blame --ignore-revs-file .git-blame-ignore-revs index.js

Copy link

socket-security bot commented Sep 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 7.19 kB raynos
npm/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +241 20.7 MB voxpelli

🚮 Removed packages: npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected])

View full report↗︎

@wesleytodd wesleytodd merged commit a57f761 into 2.0 Sep 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant