Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getGoodsDeliveryLines #655

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mizbanpaytakht
Copy link

No description provided.

@remkobrenters
Copy link
Collaborator

Before it can be merged can you fix the missing newline (see ci check)

@remkobrenters
Copy link
Collaborator

@DannyvdSluijs not sure if it is a stupid question but do you think it is possible to auto generate the getters for the child collection items? Or is there something different between the various models and their relations making this a piece of logic that needs to be added on a per-model situation?

@DannyvdSluijs
Copy link
Contributor

@DannyvdSluijs not sure if it is a stupid question but do you think it is possible to auto generate the getters for the child collection items? Or is there something different between the various models and their relations making this a piece of logic that needs to be added on a per-model situation?

That is actually a good suggestion. At this point I’m not sure if this can be done easily. I do know that non generated code is being kept when regenerating. So there is nothing blocking adding an additional getter as a short term fix.

When I have time available I can look into the generating code and see if we can add collection getters.

One other idea I’m having (but struggling to find the time for) is to have the manual work I do frequent updates turned into a GitHub workflow.

@remkobrenters
Copy link
Collaborator

Get it. Understand it is a bit hard to find the time for this. Was more thinking out loud based on this stalled PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants