fix: Make sure Assert::assertIsList correctly asserts an array as list #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitelg
force-pushed
the
fix/assert-list
branch
from
cfe1638
to
1be0814
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of this issue: #212
I decided to also bring this up into this repo, to make sure it also works for older PHPUnit versions.
for PHPUnit 11 it is fixed here: sebastianbergmann/phpunit#6027
but the
phpstan-assertannotations are not used in older versions. I hope this is okay.I also add it to the 1.4.x branch, is we could not update to 2.x yet, because of missing plugin compatibility.