-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CKEditor, Common and Updater plugins #971
Conversation
Looks like that makes us PHP7.4 incompatible. In a way that's fine as 7.4 is EOL now, but I think our Docker builds are still using 7.4, so we'd need to update that. |
Seems to be caused by some dependencies in Common Plugin requiring php 8+. But I only use those packages when I know that the php version is 8+ so it is kind of a false negative. I wouldn't want to make php 8+ a hard requirement for using Common Plugin. I only recently made php 7 a requirement. |
I have removed the packages that require php 8+, and now the CI test for php 7.4 is successful, but those for php 7.2 and 7.3 still fail but for other dependencies. Maybe there is no need to run the tests for php 7.2 and 7.3? |
Yes, the 7.2 and 7.3 have been failing for quite some time. I kept them in for reference, but we can remove them soon. |
This pull request has been mentioned on phpList Discuss. There might be relevant details there: https://discuss.phplist.org/t/3-6-14-release-candidate-ready-for-testing/9109/1 |
This pull request has been mentioned on phpList Discuss. There might be relevant details there: https://discuss.phplist.org/t/phplist-3-6-14-released-security-release/9158/1 |
Description
Update the composer.lock file to use the latest CKEditor, Common and Updater plugins.
Related Issue
Screenshots (if appropriate):