Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CKEditor, Common and Updater plugins #971

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

bramley
Copy link
Contributor

@bramley bramley commented Jul 27, 2023

Description

Update the composer.lock file to use the latest CKEditor, Common and Updater plugins.

Related Issue

Screenshots (if appropriate):

@michield
Copy link
Member

Looks like that makes us PHP7.4 incompatible. In a way that's fine as 7.4 is EOL now, but I think our Docker builds are still using 7.4, so we'd need to update that.

@bramley
Copy link
Contributor Author

bramley commented Jul 27, 2023

Seems to be caused by some dependencies in Common Plugin requiring php 8+. But I only use those packages when I know that the php version is 8+ so it is kind of a false negative.

I wouldn't want to make php 8+ a hard requirement for using Common Plugin. I only recently made php 7 a requirement.

@bramley
Copy link
Contributor Author

bramley commented Jul 27, 2023

I have removed the packages that require php 8+, and now the CI test for php 7.4 is successful, but those for php 7.2 and 7.3 still fail but for other dependencies. Maybe there is no need to run the tests for php 7.2 and 7.3?

@michield
Copy link
Member

Yes, the 7.2 and 7.3 have been failing for quite some time. I kept them in for reference, but we can remove them soon.

@michield michield self-requested a review July 27, 2023 10:46
@aulona1 aulona1 changed the base branch from main to release-3.6.14 September 13, 2023 14:58
@aulona1 aulona1 merged commit d5c319e into phpList:release-3.6.14 Sep 13, 2023
4 of 6 checks passed
@phpListDockerBot
Copy link
Contributor

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/3-6-14-release-candidate-ready-for-testing/9109/1

@bramley bramley deleted the update_plugins branch September 18, 2023 22:26
@phpListDockerBot
Copy link
Contributor

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/phplist-3-6-14-released-security-release/9158/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants