Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add void return type in DoctrineSchemaCompilerPass and MessageQueueCollector #1312

Closed
wants to merge 2 commits into from
Closed

Add void return type in DoctrineSchemaCompilerPass and MessageQueueCollector #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22fcd03
Add `void` return type in DoctrineSchemaCompilerPass
ruudk Aug 17, 2023
d6e8607
Add `void` return type in MessageQueueCollector
ruudk Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/enqueue-bundle/Profiler/MessageQueueCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@

class MessageQueueCollector extends AbstractMessageQueueCollector
{
/**
* @return void
*/
public function collect(Request $request, Response $response, Throwable $exception = null)

Check failure on line 14 in pkg/enqueue-bundle/Profiler/MessageQueueCollector.php

View workflow job for this annotation

GitHub Actions / Static analysis 

Parameter $request of method Enqueue\Bundle\Profiler\MessageQueueCollector::collect() has invalid typehint type Symfony\Component\HttpFoundation\Request.
{
$this->collectInternal($request, $response);
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/enqueue/Doctrine/DoctrineSchemaCompilerPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

class DoctrineSchemaCompilerPass implements CompilerPassInterface
{
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
if (false === $container->hasDefinition('doctrine')) {
return;
Expand Down
Loading