Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use #[AsCommand] attribute on commands #1311

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Use #[AsCommand] attribute on commands #1311

merged 4 commits into from
Oct 22, 2023

Commits on Oct 15, 2023

  1. Use #[AsCommand] attribute on commands 

    Fixes the following deprecations:

```json
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Consumption\\ConfigurableConsumeCommand\" class instead.",
    "count": 1
  },
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Client\\ConsumeCommand\" class instead.",
    "count": 1
  },
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Client\\ProduceCommand\" class instead.",
    "count": 1
  },
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Client\\SetupBrokerCommand\" class instead.",
    "count": 1
  },
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Client\\RoutesCommand\" class instead.",
    "count": 1
  },
```
    @ruudk
    ruudk committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    bbe1e6e View commit details
    Browse the repository at this point in the history

  2. Run PHPStan on 8.0 

    This way it understands attributes.
    @ruudk
    ruudk committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    70d8117 View commit details
    Browse the repository at this point in the history

  3. Change PHP version in Docker to 8.2

    @ruudk
    ruudk committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    3954ded View commit details
    Browse the repository at this point in the history

  4. Fix CI 

    Credits to VincentLanglet
    @ruudk
    ruudk committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    774ccdf View commit details
    Browse the repository at this point in the history