Add Producer events #728
Merged
Add Producer events #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaileu
reviewed
Oct 17, 2024
| @@ -63,6 +65,12 @@ public function publish($msgBody, $routingKey = null, $additionalProperties = [] | |||
| } | |||
|
|
|||
| $real_routingKey = $routingKey !== null ? $routingKey : $this->defaultRoutingKey; | |||
There was a problem hiding this comment.
$real_routingKey == routingKey ?? $this->defaultRoutingKey;
mihaileu
approved these changes
Oct 17, 2024
|
thanks foe your pr |
|
This PR introduces a bug. Constant |
|
fixed in #729 |
|
Thank you, and apologies for the regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Consumers have events which allow users of the bundle to add custom code. This PR adds this support to Producers as well. Really useful for project specific logging, message format validation, etc.
The only real difference between the Consumer and Producer events is the addition of the
routingKeyfield in the Events, as$producer->routingKeyis only set in the case where it is explicitly set, and not in the case wheredefaultRoutingKeyis used. This PR currently works around this by providing that extra field, but it might be better to changeProducer.php(line 67) from:to
and then removing the extra
routingKeyfield from the Events. Happy to take feedback on which way you'd prefer this one go.My use case for this support is message validation prior to publishing.