refactor: Refactor SingleDiagnosticAnalyzer::Analyze #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second of the Cardinality inspired maintainability analyzers.
kryptt
force-pushed
the
refactor-analyze
branch
2 times, most recently
from
98d8985
to
0bfc1b9
Compare
This ensures single responsibility of the Analyze method itself;
kryptt
force-pushed
the
refactor-analyze
branch
from
0bfc1b9
to
501c14c
Compare
kryptt
changed the title
kryptt
changed the title
bcollamore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes Analyze return an enumerable list of diagnosis errors