-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for spire controller manager #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofranssen
force-pushed
the
spire-controller-manager
branch
12 times, most recently
from
January 10, 2023 10:33
7c8df12
to
2ee0caa
Compare
marcofranssen
force-pushed
the
spire-controller-manager
branch
3 times, most recently
from
January 10, 2023 10:52
f575c7e
to
9c01547
Compare
marcofranssen
changed the title
spire controller manager
Add support for spire controller manager
Jan 10, 2023
marcofranssen
force-pushed
the
spire-controller-manager
branch
10 times, most recently
from
January 16, 2023 09:25
2450fce
to
d51d95d
Compare
marcofranssen
commented
Jan 16, 2023
charts/spire/charts/spire-server/templates/controller-manager-configmap.yaml
Outdated
Show resolved
Hide resolved
marcofranssen
force-pushed
the
spire-controller-manager
branch
2 times, most recently
from
January 16, 2023 09:39
629cd00
to
b63df5a
Compare
marcofranssen
force-pushed
the
spire-controller-manager
branch
10 times, most recently
from
January 17, 2023 12:14
88ac940
to
0a8c486
Compare
marcofranssen
force-pushed
the
spire-controller-manager
branch
from
January 17, 2023 12:57
0a8c486
to
8592ffa
Compare
e.g. if deploying with spire-65de556ac Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
…ler-manager setup Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]> Co-authored-by: Gert Jan Kamstra <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
marcofranssen
force-pushed
the
spire-controller-manager
branch
from
January 17, 2023 13:08
8592ffa
to
15486f4
Compare
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
gjkamstra
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few questions.
charts/spire/charts/spire-server/templates/controller-manager-webhook.yaml
Show resolved
Hide resolved
charts/spire/charts/spire-server/templates/controller-manager-webhook.yaml
Show resolved
Hide resolved
gjkamstra
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
strange, where is my commits 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71