Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spire controller manager #102

Merged
merged 9 commits into from
Jan 18, 2023

Conversation

marcofranssen
Copy link
Member

@marcofranssen marcofranssen commented Jan 9, 2023

Closes #71

@marcofranssen marcofranssen force-pushed the spire-controller-manager branch 12 times, most recently from 7c8df12 to 2ee0caa Compare January 10, 2023 10:33
@marcofranssen marcofranssen force-pushed the spire-controller-manager branch 3 times, most recently from f575c7e to 9c01547 Compare January 10, 2023 10:52
@marcofranssen marcofranssen changed the title spire controller manager Add support for spire controller manager Jan 10, 2023
@marcofranssen marcofranssen force-pushed the spire-controller-manager branch 10 times, most recently from 2450fce to d51d95d Compare January 16, 2023 09:25
@marcofranssen marcofranssen force-pushed the spire-controller-manager branch 2 times, most recently from 629cd00 to b63df5a Compare January 16, 2023 09:39
@marcofranssen marcofranssen marked this pull request as ready for review January 16, 2023 15:49
@marcofranssen marcofranssen requested a review from a team as a code owner January 16, 2023 15:49
@marcofranssen marcofranssen force-pushed the spire-controller-manager branch 10 times, most recently from 88ac940 to 0a8c486 Compare January 17, 2023 12:14
marcofranssen and others added 7 commits January 17, 2023 14:08
e.g. if deploying with spire-65de556ac

Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Co-authored-by: Gert Jan Kamstra <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Copy link
Contributor

@gjkamstra gjkamstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few questions.

Copy link
Contributor

@gjkamstra gjkamstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcofranssen marcofranssen merged commit 937e896 into main Jan 18, 2023
@marcofranssen marcofranssen deleted the spire-controller-manager branch January 18, 2023 10:14
@developer-guy
Copy link
Contributor

strange, where is my commits 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants