-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add couchbase govk #193
base: master
Are you sure you want to change the base?
Add couchbase govk #193
Conversation
Hi 👋 , I had looked at testcontainers for gokv in the past (and seen it used elsewhere before that), and I don't remember what exactly it was, but for gokv there was some deficiency and I chose to go with this instead: Lines 41 to 135 in c954c54
And the container stop at the end is also here: Lines 139 to 150 in c954c54
Maybe the deficiency doesn't exist anymore, but even then I'd like the testing to be consistent across store implementations. So either all other implementations should switch to testcontainers as well, or probably easier to switch the PR to start the container with that Magefile. It will require at least the addition of |
ok I will fix it |
@philippgille I think I find how to prepare the couchbase image for this test. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 63.64% 63.64%
=======================================
Files 25 25
Lines 2107 2107
=======================================
Hits 1341 1341
Misses 651 651
Partials 115 115 ☔ View full report in Codecov by Sentry. |
This PR add supports for couchbase using gocb api version 2
To be possible run the tests you have two options
COUCHBASE_SERVER
must contains the connection string examplecouchbase://localhost
COUCHBASE_BUCKET
must contains the name of the bucket to testCOUCHBASE_USERNAME
&COUCHBASE_PASSWORD
must contains the user and pass needed to access the couchbaseThis can be done following this procedure using docker
github.com/testcontainers/testcontainers-go
(you can check here and here how it works.if there is no env var
COUCHBASE_SERVER
set, the tests will be skipped.