Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace infinite scrolling with pagination in query tool data output for better UX and performance. #7864

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

adityatoshniwal
Copy link
Contributor

No description provided.

@adityatoshniwal adityatoshniwal force-pushed the pagination-grid branch 3 times, most recently from 08729f9 to 206c61d Compare August 29, 2024 12:38
@adityatoshniwal adityatoshniwal changed the title This is WIP - Pagination changes. @adityatoshniwal Replace infinite scrolling with pagination in query tool data output for better UX and performance. Aug 29, 2024
@adityatoshniwal adityatoshniwal changed the title @adityatoshniwal Replace infinite scrolling with pagination in query tool data output for better UX and performance. Replace infinite scrolling with pagination in query tool data output for better UX and performance. Aug 29, 2024
@yogeshmahajan-1903
Copy link
Contributor

Some issues found -
1.When all rows are selected > Rows selected count is incorrect
Screenshot 2024-09-26 at 12 45 44 PM

2.When custom page range is selected and clicked next page, incorrect records are selected -
Screenshot 2024-09-26 at 12 46 04 PM

Copy link
Contributor

@akshay-joshi akshay-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Rename "Showing:" to "Showing Rows:" and "Edit page range" tooltip to "Edit range".
  2. Click on Edit page range or Page Number, change the range or page number, and click anywhere outside in pgAdmin. It won't update the results.
  3. Please add validation for page number 0 or range in opposite order like 10 to 1. It throws an error 'NOT FOUND position out of bound' in the Messages tab.

web/config.py Outdated Show resolved Hide resolved
docs/en_US/query_tool_toolbar.rst Outdated Show resolved Hide resolved
docs/en_US/preferences.rst Outdated Show resolved Hide resolved
docs/en_US/images/query_data_pagination.png Outdated Show resolved Hide resolved
docs/en_US/images/preferences_sql_results_grid.png Outdated Show resolved Hide resolved
@akshay-joshi akshay-joshi merged commit 6322674 into pgadmin-org:master Oct 1, 2024
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants