Datasources as CRDs #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgbernalp
force-pushed
the
datasources-as-crds
branch
2 times, most recently
from
789d819
to
41ef95c
Compare
|
Draft because Requires #8 |
Merged
jgbernalp
force-pushed
the
datasources-as-crds
branch
2 times, most recently
from
d92e69a
to
a7e99e3
Compare
Nexucis
reviewed
Mar 28, 2024
api/v1alpha1/perses_datasource.go
Outdated
| ) | ||
|
|
||
| type Datasource struct { | ||
| persesv1.Datasource `json:",inline"` |
There was a problem hiding this comment.
isn't a bit weird to put the complete datasource object ?
The datasource object also contains the metadata struct and probably each overlap don't you think ?
How about putting instead DatasourceSpec ? That would be the same thing for the dashboard. Using DashboardSpec instead of the object Dashboard from Perses
There was a problem hiding this comment.
Yes indeed is more clear that way, I created #10 to fix also the dashboards
Signed-off-by: Gabriel Bernal <[email protected]>
jgbernalp
force-pushed
the
datasources-as-crds
branch
from
a7e99e3
to
90f7960
Compare
Nexucis
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Perses Datasources as CRDs: