chore: fix linting #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
basti1302
commented
Oct 9, 2024
basti1302
commented
- pin the Go version used to run golangci-lint to Go 1.22
- fix linting issues reported by golangci-lint (superfluos nil checks for slices)
- remove redundant package aliases
Nexucis
reviewed
Oct 9, 2024
.github/workflows/go.yml
Outdated
| @@ -47,6 +47,8 @@ jobs: | |||
| - name: checkout | |||
| uses: actions/checkout@v4 | |||
| - uses: perses/[email protected] | |||
There was a problem hiding this comment.
Suggested change
| - uses: perses/github-actions@v0.1.0 | |
| - uses: perses/github-actions@v0.6.0 |
With that you can get Golang v1.23 and then you can upgrade golangci-lint to the latest version (v1.61.0)
There was a problem hiding this comment.
Suggested change
| - uses: perses/github-actions@v0.1.0 | |
| - uses: perses/github-actions@v0.6.0 | |
| - uses: ./.github/perses-ci/actions/setup_environment | |
| with: | |
| enable_go: true | |
| enable_go_cache: false | |
| enable_npm: false | |
| - name: golangci-lint | |
| uses: golangci/[email protected] | |
| with: | |
| # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. | |
| version: v1.61.0 |
There was a problem hiding this comment.
Okay, I'll give that a try.
|
I wrote in the last PR that I don't know exactly how to fix the linting but after thinking again this should actually do it (pin the Go version in the GH action). |
* pin the Go version used to run golangci-lint to Go 1.22 * fix linting issues reported by golangci-lint (superfluos nil checks for slices) * remove redundant package aliases Signed-off-by: Bastian Krol <[email protected]>
Signed-off-by: Bastian Krol <[email protected]>
|
@Nexucis I applied your suggestion, CI is still green 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.