Merge pull request #418 from permutive-engineering/async-leak

Fix potential async leak
permutive-engineering · Nov 10, 2022 · 0b25e9c · 0b25e9c
2 parents 502de2f + c828c65
commit 0b25e9c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...ubsub-grpc/src/main/scala/com/permutive/pubsub/producer/grpc/internal/FutureInterop.scala b/...ubsub-grpc/src/main/scala/com/permutive/pubsub/producer/grpc/internal/FutureInterop.scala
@@ -23,9 +23,9 @@ import com.google.common.util.concurrent.MoreExecutors
 
 private[internal] object FutureInterop {
   def fFromFuture[F[_]: Async, A](future: F[ApiFuture[A]]): F[A] =
-    future.flatMap { futA =>
-      Async[F]
-        .async[A] { cb =>
+    Async[F]
+      .async[A] { cb =>
+        future.flatMap { futA =>
           Sync[F].delay {
             val futureApi = futA
             addCallback(futureApi)(cb)
@@ -47,7 +47,7 @@ private[internal] object FutureInterop {
             )
           }
         }
-    }
+      }
 
   @inline
   private def addCallback[A](futA: ApiFuture[A])(cb: Either[Throwable, A] => Unit): Unit =