PMM-13057 New telemetry endpoint. #3230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3230 +/- ##
==========================================
+ Coverage 43.41% 43.46% +0.04%
==========================================
Files 360 360
Lines 43979 43976 -3
==========================================
+ Hits 19093 19113 +20
+ Misses 23224 23203 -21
+ Partials 1662 1660 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JiriCtvrtka
force-pushed
the
PMM-13057-new-telemetry
branch
from
014ecf7
to
c444835
Compare
1 task
JiriCtvrtka
requested review from
ademidoff and
BupycHuk
and removed request for
a team
BupycHuk
approved these changes
Oct 22, 2024
ademidoff
reviewed
Oct 31, 2024
| @@ -20,7 +20,7 @@ import ( | |||
| "context" | |||
| "os" | |||
|
|
|||
| pmmv1 "github.com/percona-platform/saas/gen/telemetry/events/pmm" | |||
| genericv1 "github.com/percona/saas/gen/telemetry/generic" | |||
There was a problem hiding this comment.
I would call it telemetryv1, since generic doesn't tell much when you see it in the code.
There was a problem hiding this comment.
Both (genericv1 and reporter) renamed to telemetryv1.
JiriCtvrtka
force-pushed
the
PMM-13057-new-telemetry
branch
from
d9c6bd9
to
591a26f
Compare
ademidoff
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13057
Link to the Feature Build: Percona-Lab/pmm-submodules#3736