Skip to content

Commit

Permalink
PMM-7222 Remove NOT_EQUAL and NOT_REGEXP filters (#647)
Browse files Browse the repository at this point in the history
  • Loading branch information
AlekSi authored Dec 28, 2020
1 parent d681295 commit 947e30b
Show file tree
Hide file tree
Showing 6 changed files with 66 additions and 106 deletions.
12 changes: 2 additions & 10 deletions api/managementpb/ia/json/client/alerts/list_alerts_responses.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 8 additions & 16 deletions api/managementpb/ia/json/ia.json
Original file line number Diff line number Diff line change
Expand Up @@ -263,15 +263,13 @@
"x-order": 1
},
"type": {
"description": "FilterType represents filter matching type.\n\n - EQUAL: =\n - NOT_EQUAL: !=\n - REGEX: =~\n - NOT_REGEX: !~",
"description": "FilterType represents filter matching type.\n\n - EQUAL: =\n - REGEX: =~",
"type": "string",
"default": "FILTER_TYPE_INVALID",
"enum": [
"FILTER_TYPE_INVALID",
"EQUAL",
"NOT_EQUAL",
"REGEX",
"NOT_REGEX"
"REGEX"
],
"x-order": 0
},
Expand Down Expand Up @@ -1536,15 +1534,13 @@
"x-order": 1
},
"type": {
"description": "FilterType represents filter matching type.\n\n - EQUAL: =\n - NOT_EQUAL: !=\n - REGEX: =~\n - NOT_REGEX: !~",
"description": "FilterType represents filter matching type.\n\n - EQUAL: =\n - REGEX: =~",
"type": "string",
"default": "FILTER_TYPE_INVALID",
"enum": [
"FILTER_TYPE_INVALID",
"EQUAL",
"NOT_EQUAL",
"REGEX",
"NOT_REGEX"
"REGEX"
],
"x-order": 0
},
Expand Down Expand Up @@ -1990,15 +1986,13 @@
"x-order": 1
},
"type": {
"description": "FilterType represents filter matching type.\n\n - EQUAL: =\n - NOT_EQUAL: !=\n - REGEX: =~\n - NOT_REGEX: !~",
"description": "FilterType represents filter matching type.\n\n - EQUAL: =\n - REGEX: =~",
"type": "string",
"default": "FILTER_TYPE_INVALID",
"enum": [
"FILTER_TYPE_INVALID",
"EQUAL",
"NOT_EQUAL",
"REGEX",
"NOT_REGEX"
"REGEX"
],
"x-order": 0
},
Expand Down Expand Up @@ -2470,15 +2464,13 @@
"x-order": 1
},
"type": {
"description": "FilterType represents filter matching type.\n\n - EQUAL: =\n - NOT_EQUAL: !=\n - REGEX: =~\n - NOT_REGEX: !~",
"description": "FilterType represents filter matching type.\n\n - EQUAL: =\n - REGEX: =~",
"type": "string",
"default": "FILTER_TYPE_INVALID",
"enum": [
"FILTER_TYPE_INVALID",
"EQUAL",
"NOT_EQUAL",
"REGEX",
"NOT_REGEX"
"REGEX"
],
"x-order": 0
},
Expand Down
106 changes: 48 additions & 58 deletions api/managementpb/ia/rules.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions api/managementpb/ia/rules.proto
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ enum FilterType {
// =
EQUAL = 1;
// !=
NOT_EQUAL = 2;
// NOT_EQUAL = 2;

// =~
REGEX = 3;
// !~
NOT_REGEX = 4;
// NOT_REGEX = 4;

}

// Filter repsents a single filter condition.
Expand Down

0 comments on commit 947e30b

Please sign in to comment.