Fix authentication for Azure API in xbcloud #1611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrivera
commented
Sep 17, 2024
| @@ -558,15 +558,15 @@ TEST(azure_signer, basicDNS) { | |||
| req.append_payload("test", 4); | |||
| Azure_signer signer( | |||
| "my-storage-account", | |||
| "zUfvsKXc6+2RMJCwvnElnG/" | |||
| "Kk7wxQ8V4TPXIuZ53qFwJNtpLUEjYdBe9iGTkMgwUGFHVfFgn2qkgoqDP/b3OAg==", | |||
| "zUfvsKXcAO2RMJCwvnElnG/" | |||
There was a problem hiding this comment.
Now this key contains a NULL byte when decoded, and it ends in \r to check that the request signing is correctly done
imrivera
force-pushed
the
fix_azure_key_signing_in_xbcloud
branch
from
d2f7dc8
to
cd7678c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem when an Azure key contained a null byte, the result when decoding base64 was trimmed and part of the key was lost.
Also if the decoded binary key started or ended with white space, some bytes would be discarded.
This PR fixes both problems