Update help button design #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrbeckm
reviewed
Aug 26, 2023
| @@ -3,5 +3,5 @@ | |||
| --- | |||
| {{ content }} | |||
| <a href="/problem.html" class="help-button-holder"> | |||
| <i class="fa fa-question fa-lg help-button"></i> | |||
| <i class="help-button" title="Hilfe bei der Installation">?</i> | |||
There was a problem hiding this comment.
I am undecided between Hilfe and Probleme.
There was a problem hiding this comment.
Yeah, I was thinking about that too... I mean, technically neither is wrong. But if we go with "Probleme" I'd suggest going for "Probleme bei der Installation?" with a question mark at the end. Sounds better to me, imo.
There was a problem hiding this comment.
I guess no one will read the tool tip. So if we get weird mails, we can change it.
chrbeckm
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor tweaks to make the button a bit more appealing.