Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): navigation + buttons #311

Merged
merged 3 commits into from
Oct 20, 2024
Merged

fix(styling): navigation + buttons #311

merged 3 commits into from
Oct 20, 2024

Conversation

jonrxu
Copy link
Contributor

@jonrxu jonrxu commented Oct 13, 2024

  • Some styling changes for navigation and buttons, and other small fixes.
  • Replacing outdated CSS with new Tailwind styling.
Screenshot 2024-10-13 at 2 34 20 PM

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (ef44d80) to head (69f6d87).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files          62       62           
  Lines        2681     2681           
=======================================
  Hits         2424     2424           
  Misses        257      257           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vcai122 vcai122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a more general question. If we are revamping? Should we still keep the styled components such as Button, Link, etc.?

frontend/components/dashboard/DashboardHeader.tsx Outdated Show resolved Hide resolved
frontend/components/form/StatusBar.tsx Outdated Show resolved Hide resolved
frontend/components/styles/Buttons.tsx Outdated Show resolved Hide resolved
frontend/components/styles/Buttons.tsx Outdated Show resolved Hide resolved
frontend/components/styles/Nav.tsx Show resolved Hide resolved
frontend/components/styles/Nav.tsx Outdated Show resolved Hide resolved
frontend/components/styles/sizes.ts Show resolved Hide resolved
@jonrxu jonrxu merged commit 4f14a2f into master Oct 20, 2024
9 checks passed
@jonrxu jonrxu deleted the jonx/sidebar-changes branch October 20, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants