Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dining insights Fixes #632

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Dining insights Fixes #632

merged 2 commits into from
Oct 20, 2024

Conversation

baronhsieh2005
Copy link
Contributor

Fixes:

  1. Changed the insights graph bug caused by API returning faulty data from the pastbalances route. Solved by filtering out zero values/data points between two non-zero data points and append currentBalances at the current day in the graph. Shoutout to @JHawk0224 and @jonathanmelitski for the help!
  2. Changed adapter to view binding implementation

@trinif trinif merged commit f4bf2aa into main Oct 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinif trinif trinif approved these changes

@meiron03 meiron03 Awaiting requested review from meiron03

@Akula112233 Akula112233 Awaiting requested review from Akula112233

@Divak2004 Divak2004 Awaiting requested review from Divak2004

@vavali08 vavali08 Awaiting requested review from vavali08

@joemacd joemacd Awaiting requested review from joemacd

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baronhsieh2005 @trinif