Add Submissions #718

owlester12 · 2024-09-05T03:33:19Z

No description provided.

* Update main.ts * Update frontend dependencies (#616) Upgrade from Node 14 to Node 20 and bump frontend dependency versions to current. --------- Co-authored-by: Julian Weng <[email protected]> * Update README.md * Update README backend instructions and intro blurb * Fix admin page access on frontend. (#626) Add frontend check for existing pre-loaded permissions on /admin. * Removed deprecated QuestionResponse model and duplicate line (#625) * Remove deprecated QuestionResponse model * remove duplicate line: 'rank field in Club' * made migrations after deleting QuestionResponse * Streamline django storages config (#618) * Add staticfiles * Fix AWS bucket routing for boto * Try setting credentials through env vars * Try renaming env vars? * Set AWS region * add back staticfiles * Remove region and signature version * Move credentials to new API * Use env variables and remove staticfiles * Add back staticfiles * Make code look pretty --------- Co-authored-by: Rohan Moniz <[email protected]> * Add hour to displayed application deadline (#628) * Add hour for application due dates * Make linter happy * Specify Eastern time zone * Display username if name is empty (#637) * finished changes * Remove Wharton applications from user profile * Fix weird artifacts from merge --------- Co-authored-by: Joy Liu <[email protected]> Co-authored-by: Julian Weng <[email protected]> Co-authored-by: Rohan Moniz <[email protected]> Co-authored-by: Thomas Ngulube <[email protected]> Co-authored-by: Owen Lester <[email protected]>

* Bump debounce timeout to 400ms * Make linter happy

gitguardian · 2024-09-05T03:33:25Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10282361	Triggered	Generic High Entropy Secret	`54e1543`	backend/pennclubs/settings/ci.py	View secret
10282361	Triggered	Generic High Entropy Secret	`54e1543`	backend/pennclubs/settings/development.py	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

codecov · 2024-09-05T03:35:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (fbedec8) to head (4daa2d4).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          31       31           
  Lines        6850     6850           
=======================================
  Hits         4891     4891           
  Misses       1959     1959

Flag	Coverage Δ
	`71.40% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

julianweng

Looks good generally, had a couple of nits and things that could be changed from the existing ported implementation. Thanks for taking the time to revisit this!

julianweng · 2024-09-05T16:14:32Z

frontend/package.json

Is this necessary to pass lint?

julianweng · 2024-09-05T16:38:39Z

frontend/pages/settings.tsx

  authenticated: boolean | null
+  submissions: ApplicationSubmission[]
+  whartonapplications: any


Nit: camel case variable name and adding types would be nice (I know the reference code didn't have either but it would be good practice)

julianweng · 2024-09-05T16:40:27Z

frontend/pages/settings.tsx

+    {
+      name: 'applications',
+      label: 'Applications',
+      content: <ApplicationsPage whartonapplications={whartonapplications} />,


Now that the page is more visible in the profile, would be nice to clarify that it's for Wharton Cycle applications specifically (maybe change it to all eventually but not needed now).

julianweng

Thanks for taking the time to fix the nits, just left two more and it should be ready!

julianweng · 2024-09-08T17:40:55Z

frontend/components/Applications.tsx

-            </CardWrapper>
-          ))
+          <div>
+            <Text>Only Wharton applications displayed here!</Text>


Maybe rephrase as "Note: only current Wharton applications are displayed on this page"

Made changes

julianweng · 2024-09-08T17:41:18Z

frontend/pages/settings.tsx

@@ -87,7 +87,7 @@ const Settings = ({
    {
      name: 'applications',
      label: 'Applications',
-      content: <ApplicationsPage whartonapplications={whartonapplications} />,
+      content: <ApplicationsPage whartonapplications={whartonApplications} />,


Could be appropriate to also rename the prop in ApplicationsPage to be camelcase for simplicity

Made changes

julianweng

Hi, thanks for making the changes, can you fix the type check errors (tsc) with your change? Also, there is probably a better way of handling the rename than declaring and immediately spreading a separate returner variable that would be clearer to read.

owlester12 · 2024-09-28T22:47:58Z

Both issues should fixed. Some of the checks are still failing– something about the Codecov report not uploading? I'm unsure what that means.

owlester12 and others added 17 commits March 17, 2024 20:13

finished changes

bbb55b5

Bump debounce timeout to 400ms (#640)

b11ee47

* Bump debounce timeout to 400ms * Make linter happy

merge master

8525b8c

small changes

5863870

added type

626cf15

merging

9365a35

merging

00110d9

merge

5efd906

merge

4affb1f

deleted file

2f0c577

merge

54e1543

fix submissions page

c485400

applications

424905c

changes

fd75fb8

a

db92122

remove ruff

8821e7e

just submissions

f072705

owlester12 requested a review from julianweng September 5, 2024 03:52

owlester12 added 2 commits September 5, 2024 08:38

add applications page

45071d6

fix formatting

d9c01eb

julianweng requested changes Sep 5, 2024

View reviewed changes

fixing nits

b98818f

owlester12 requested a review from julianweng September 6, 2024 21:55

julianweng requested changes Sep 8, 2024

View reviewed changes

owlester12 added 2 commits September 8, 2024 13:45

fixed Nits

0cf8f46

merge master

3b71f93

owlester12 requested a review from julianweng September 9, 2024 15:54

julianweng requested changes Sep 24, 2024

View reviewed changes

owlester12 added 3 commits September 27, 2024 17:01

update types

39f74f8

merge

ab07513

change type

4daa2d4

owlester12 requested a review from julianweng September 28, 2024 22:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Submissions #718

Add Submissions #718

owlester12 commented Sep 5, 2024

gitguardian bot commented Sep 5, 2024 •

edited

Loading

codecov bot commented Sep 5, 2024 •

edited

Loading

julianweng left a comment

julianweng Sep 5, 2024

julianweng Sep 5, 2024

julianweng Sep 5, 2024

julianweng left a comment

julianweng Sep 8, 2024

owlester12 Sep 8, 2024

julianweng Sep 8, 2024

owlester12 Sep 8, 2024

julianweng left a comment

owlester12 commented Sep 28, 2024

Add Submissions #718

Are you sure you want to change the base?

Add Submissions #718

Conversation

owlester12 commented Sep 5, 2024

gitguardian bot commented Sep 5, 2024 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

codecov bot commented Sep 5, 2024 • edited Loading

Codecov Report

julianweng left a comment

Choose a reason for hiding this comment

julianweng Sep 5, 2024

Choose a reason for hiding this comment

julianweng Sep 5, 2024

Choose a reason for hiding this comment

julianweng Sep 5, 2024

Choose a reason for hiding this comment

julianweng left a comment

Choose a reason for hiding this comment

julianweng Sep 8, 2024

Choose a reason for hiding this comment

owlester12 Sep 8, 2024

Choose a reason for hiding this comment

julianweng Sep 8, 2024

Choose a reason for hiding this comment

owlester12 Sep 8, 2024

Choose a reason for hiding this comment

julianweng left a comment

Choose a reason for hiding this comment

owlester12 commented Sep 28, 2024

gitguardian bot commented Sep 5, 2024 •

edited

Loading

codecov bot commented Sep 5, 2024 •

edited

Loading