Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimenting with AU ASGS format #71

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions import/source/asgs.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const file = require('../../import/file')

module.exports = {
ingress: file,
record_separator: /\r?\n/,
format: 'json',
mapper: require('./asgs/map/place')
}
17 changes: 17 additions & 0 deletions import/source/asgs/map/geometries.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
const _ = require('lodash')
const format = require('../../../format')
const Geometry = require('../../../../model/Geometry')

function mapper (place, doc) {
const geometry = _.get(doc, 'geometry')
const isPolygon = _.get(geometry, 'type', '').trim().toUpperCase().endsWith('POLYGON')

if (geometry) {
place.addGeometry(new Geometry(
format.from('geometry', 'geojson', geometry),
isPolygon ? 'boundary' : 'centroid'
))
}
}

module.exports = mapper
14 changes: 14 additions & 0 deletions import/source/asgs/map/names.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
const _ = require('lodash')
const Name = require('../../../../model/Name')

function mapper (place, properties) {
// remove 'disambiguation' tokens from name suffix
// see: https://github.com/whosonfirst-data/whosonfirst-data/issues/885
let name = _.get(properties, 'SSC_NAME16', '')
name = name.replace(/(\s+([-֊־‐‑﹣]|[([])).*$/, '')

place.addName(new Name('und', 'default', false, name))
place.addName(new Name('eng', 'preferred', false, name))
}

module.exports = mapper
35 changes: 35 additions & 0 deletions import/source/asgs/map/place.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
const _ = require('lodash')
const Identity = require('../../../../model/Identity')
const Ontology = require('../../../../model/Ontology')
const Place = require('../../../../model/Place')

const map = {
names: require('./names'),
properties: require('./properties'),
geometries: require('./geometries')
}

function mapper (doc) {
// get document properties
const properties = _.get(doc, 'properties')
if (!_.isPlainObject(properties)) { return null }

// do not map records with no valid id or name
if (!_.has(properties, 'SSC_CODE16')) { return null }
if (!_.has(properties, 'SSC_NAME16')) { return null }

// instantiate a new place
const place = new Place(
new Identity('asgs', _.get(properties, 'SSC_CODE16', '').toString()),
new Ontology('admin', 'suburb')
)

// run mappers
map.names(place, properties)
map.properties(place, properties)
map.geometries(place, doc)

return place
}

module.exports = mapper
9 changes: 9 additions & 0 deletions import/source/asgs/map/properties.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
const Property = require('../../../../model/Property')

function mapper (place, properties) {
for (let key in properties) {
place.addProperty(new Property(`asgs:${key}`, properties[key]))
}
}

module.exports = mapper