Fix numpy2 compatibility #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More details here: https://numpy.org/doc/stable/dev/depending_on_numpy.html#numpy-2-0-specific-advice and regarding np.sctypes: numpy/numpy#26778
SimonSegerblomRex
force-pushed
the
numpy2
branch
from
b32c926
to
cab3deb
Compare
pearu
requested changes
Jun 28, 2024
There was a problem hiding this comment.
I have one change request, otherwise LGTM!
Thanks, @SimonSegerblomRex
numpy2 doesn't support 3.8. Not sure if something more needs to be updated here..?
Thanks! I updated ci.yaml as well now to not include 3.8. |
|
Re: I think the resolution here is to make sure that |
SimonSegerblomRex
force-pushed
the
numpy2
branch
from
3b3241e
to
6f0d2a0
Compare
Thanks! Now the tests pass locally on my machine at least, but it still feels a bit shaky. |
djhoese
previously approved these changes
Jun 29, 2024
|
Perhaps some of the MacOS ARM64 failures could be fixed by #179..? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details here:
https://numpy.org/doc/stable/dev/depending_on_numpy.html#numpy-2-0-specific-advice
and regarding np.sctypes:
numpy/numpy#26778