Defining ThreeDomainSecureClient component interface #2447
Conversation
| currencyCode: string, | ||
| billingCountryCode: string, | ||
| amount: string, | ||
| includeBuyerInstallments?: boolean, |
There was a problem hiding this comment.
nit: do we want to remove the lint updates out of this PR for clarity?
There was a problem hiding this comment.
Good call. I can create a separate PR for the lint commits.
There was a problem hiding this comment.
We can leave it in for this one. But also the comment, so it is easier to trace back that it is simply a lint update and not actual code changes.
| vi.mock("../lib", () => ({ | ||
| ValidationError: vi.fn(), | ||
| })); | ||
| describe("getThreeDomainSecure returns ThreeDomainSecureComponent", () => { |
There was a problem hiding this comment.
Do we still want to keep this test?
There was a problem hiding this comment.
I moved this test further down on Line 46 as a general initialization test. Instead of mocking the ValidationError I'm just asserting that it would throw an error. Is this OK or does it change the test? I wasn't entirely sure.
There was a problem hiding this comment.
I see, yeah that should work too. My idea with that test was to capture validationError specifically since it will be one of the trace events in the future.
This is not a blocker for the PR to be merged
|
|
||
| return ThreeDomainSecureAuth; | ||
| type SdkConfig = {| | ||
| sdkToken: ?string, |
There was a problem hiding this comment.
nit: We can probably remove the ? here. It is required to be a string
There was a problem hiding this comment.
Removing this creates a flow error. I believe that it is possible for null or undefined to be returned by getSDKToken which is why it should be optional
Description
This PR is to add the framework for the
ThreeDomainSecureClientcomponent. Two additional methods ofisEligibleandshowhave been added to this component.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
https://paypal.atlassian.net/browse/DTPPCPSDK-2658
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!