update the BT min Version, add patchVersion + update unit test #2435
Conversation
| } | ||
| const versionSplit = version.split("."); | ||
| // patch could have an alpha tag | ||
| const patchSplit = versionSplit[2].split("-"); |
There was a problem hiding this comment.
do we need to validate the patch version? Is the fastlane team asking for that?
There was a problem hiding this comment.
Me and Nik thought it something good to have but we can remove it.
There was a problem hiding this comment.
With the DEFAULT_BT_VERSION & MIN_BT_VERSION having patch versions greater that 0, it seemed like a valid check.
There was a problem hiding this comment.
the only thing i'm worried about is accidentally marking current integrations as invalid. Technically, if this check is working correctly, then the merchant's integration wouldn't work anyway.
but i would check with the fastlane team to see if they have any dashboards we can watch while the SDK deploys
There was a problem hiding this comment.
With the current logic anything below 3.97.3 will throw an error, the previous logic would only throw an error for versions less than 3.97
It seems like the min version is on this specific version 3.97.3-connect-alpha.6.1
If a merchant was on 3.97.1, no error would be thrown, but I don't think that version would have the Fastlane changes?
Is that logic correct?
There was a problem hiding this comment.
i don't think this will break anything, but i also don't think it's necessary.
just for context, the first official version of BT to support Fastlane is 3.104.0. before that, the only other versions with Fastlane were:
3.95.0-connect-alpha.12
3.97.3-connect-alpha.6.1
3.103.0-fastlane-beta.7.3
nikrom17
force-pushed
the
feature/update-min-BT-version
branch
from
ea7fcf5
to
1c381eb
Compare
Description
Create a Default Version BT version to 3.107.1