Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Increase minimum label height to 20px #2422

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Increase minimum label height to 20px #2422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ui/buttons/styles/responsive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ export function buttonResponsiveStyle({
12
);

const labelHeight = max(roundUp(perc(buttonHeight, 35) + 5, 2), 12);
// A PayPal logo with min height 20px is what we need to achieve the desired look when the button is small
// A small button rendered by us is approximately 100px width by 42px height
const labelHeight = max(roundUp(perc(buttonHeight, 35) + 5, 2), 20);

const pillBorderRadius = Math.ceil(buttonHeight / 2);

Expand Down
Loading