switch to namedtuple for coordinates parameters (**BREAKS API**) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toppk thanks. I'm thinking may be you can overload the methods, making them able to accept both coordinate type and tuple. |
|
which methods? all of them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change makes the api a little bit more consistent. it creates a object (a namedtuple) for coodinates, and replaces all uses of lat/long inside noaa_sdk.noaa with this type.
in addition to api breakage, there was a coordinate truncation done in get_observations() that I moved to points() (and implemented as string formatting).
happy to further explain or correct as needed.