Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the class Activator method activate, the conditional expression was omitted so that the variable versions is always a list with elements of the form "key - value".
(Hi! 👋 Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)
What does this implement/fix? Explain your changes.
Perhaps the cause of issue #227 is that in the following code (
activator.mts
, lines 1121-1130), the value ofObject.keys( availableStubVersions).length
is always 1 because the type ofavailableStubVersions
is{[key: string]: string[]}
.The following is the change in this pull-request.
This makes variable
versions
always a list with elements of the form "key - value".Does this close any currently open issues?
#227
Any relevant logs, error output, etc?
(If it’s long, please paste to https://gist.github.com and insert the link here)
Can be found in #227
Any other comments?
Where has this been tested?