Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter events in subscription engine #637

Open
wants to merge 2 commits into
base: 3.5.x
Choose a base branch
from

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added this to the 3.5.0 milestone Oct 6, 2024
@DavidBadura DavidBadura added the enhancement New feature or request label Oct 6, 2024
Copy link

github-actions bot commented Oct 6, 2024

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.024s (±0.00%) | 3.049s (±0.00%) | -0.81%    | 46.884mb        | 34.744mb   | +34.94%     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 70.200ms (±0.00%) | 69.658ms (±0.00%) | +0.78%    | 34.234mb        | 34.234mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 879.200μs (±0.00%) | 895.200μs (±0.00%) | -1.79%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchLoad10000Events ()                | 46.192ms (±0.00%)  | 47.132ms (±0.00%)  | -2.00%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave1Event ()                     | 879.400μs (±0.00%) | 887.600μs (±0.00%) | -0.92%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000Events ()                | 201.778ms (±0.00%) | 213.798ms (±0.00%) | -5.62%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.073s (±0.00%)    | 7.110s (±0.00%)    | -0.52%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.650s (±0.00%)    | 4.664s (±0.00%)    | -0.29%    | 34.744mb        | 34.744mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 45.521ms (±0.00%)  | 49.442ms (±0.00%)  | -7.93%    | 33.835mb        | 33.835mb   | 0.00%       |
| benchLoad10000Events ()                | 901.000μs (±0.00%) | 977.900μs (±0.00%) | -7.86%    | 33.835mb        | 33.835mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.204ms (±0.00%)   | 4.188ms (±0.00%)   | +0.37%    | 37.072mb        | 37.072mb   | 0.00%       |
| benchSave10000Events () | 341.099ms (±0.00%) | 344.651ms (±0.00%) | -1.03%    | 37.144mb        | 37.144mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 871.800μs (±0.00%) | 874.600μs (±0.00%) | -0.32%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchLoad10000Events ()                | 83.190ms (±0.00%)  | 81.252ms (±0.00%)  | +2.38%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave1Event ()                     | 1.337ms (±0.00%)   | 1.357ms (±0.00%)   | -1.44%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Events ()                | 242.837ms (±0.00%) | 242.308ms (±0.00%) | +0.22%    | 34.897mb        | 34.897mb   | 0.00%       |
| benchSave10000Aggregates ()            | 11.099s (±0.00%)   | 11.118s (±0.00%)   | -0.17%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 8.682s (±0.00%)    | 8.636s (±0.00%)    | +0.53%    | 35.396mb        | 35.396mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 934.600μs (±0.00%) | 906.600μs (±0.00%) | +3.09%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchLoad10000Events ()                | 51.199ms (±0.00%)  | 48.962ms (±0.00%)  | +4.57%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave1Event ()                     | 1.053ms (±0.00%)   | 917.300μs (±0.00%) | +14.82%   | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Events ()                | 215.002ms (±0.00%) | 210.993ms (±0.00%) | +1.90%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.122s (±0.00%)    | 7.056s (±0.00%)    | +0.94%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.653s (±0.00%)    | 4.640s (±0.00%)    | +0.29%    | 33.765mb        | 33.765mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the subscription-engine-filter-events branch from 113cd50 to 95c56c8 Compare October 6, 2024 08:34
Copy link
Member

@DanielBadura DanielBadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also add a NOT IN event filter?

@DavidBadura
Copy link
Member Author

For which use case 🤔

@DanielBadura
Copy link
Member

Maybe for testing purposes, like checking what happens if an event will be dropped. It just came in my mind - nothing we need right away

@DavidBadura DavidBadura force-pushed the subscription-engine-filter-events branch from 4ed8b77 to bae4966 Compare October 15, 2024 11:36
@DavidBadura DavidBadura removed this from the 3.5.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants