Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document UDP.isValid() / UDP.status() #250

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Document UDP.isValid() / UDP.status() #250

wants to merge 3 commits into from

Conversation

aledand
Copy link

@aledand aledand commented Dec 15, 2015

spark/firmware #766 PR companion
@kennethlimcp
Copy link
Contributor

Ref: particle-iot/device-os#766

@kennethlimcp
Copy link
Contributor

Is this only valid for Photon?

We might need to extend the example a little and also give a description of what does function actually do...

@@ -3260,6 +3260,22 @@ UDP udp;
udp.leaveMulticast();
```

### isValid()

Check if the previusly bind UDP socket is valid.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in the base code and I suppose shuld work even for Core and Electron. no way to test.

going to extend example and description ... which will be much way longer that the change itself :-)

@monkbroc monkbroc changed the title Update firmware.md Document UDP.isValid() Apr 19, 2016
@technobly technobly changed the title Document UDP.isValid() Document UDP.isValid() / UDP.status() Feb 9, 2017
@technobly
Copy link
Member

This may change to UDP::status() to match the existing TCPClient::status()

@ScruffR
Copy link
Contributor

ScruffR commented Dec 29, 2017

This PR is lingering for quite some time although on the Prioritized list - why?

@rickkas7
Copy link
Contributor

This appears to be awaiting a code change that has not been merged in, and might also require some reworking to make the API more like TCPClient.
particle-iot/device-os#766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants