[Alerts] multiple election alerts (#10895)

parti-renaissance · Oct 21, 2024 · 2682251 · 2682251
1 parent 15ed82f
commit 2682251
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/src/JeMengage/Alert/AlertProvider.php b/src/JeMengage/Alert/AlertProvider.php
@@ -14,14 +14,14 @@ public function __construct(private readonly iterable $providers)
 
     public function getAlerts(Adherent $adherent): array
     {
-        $alerts = [];
+        $allAlerts = [];
 
         foreach ($this->providers as $provider) {
-            if ($alert = $provider->getAlert($adherent)) {
-                $alerts[] = $alert;
+            if ($alerts = $provider->getAlerts($adherent)) {
+                $allAlerts = array_merge($allAlerts, $alerts);
             }
         }
 
-        return $alerts;
+        return $allAlerts;
     }
 }
diff --git a/src/JeMengage/Alert/Provider/AlertProviderInterface.php b/src/JeMengage/Alert/Provider/AlertProviderInterface.php
@@ -3,9 +3,8 @@
 namespace App\JeMengage\Alert\Provider;
 
 use App\Entity\Adherent;
-use App\JeMengage\Alert\Alert;
 
 interface AlertProviderInterface
 {
-    public function getAlert(Adherent $adherent): ?Alert;
+    public function getAlerts(Adherent $adherent): array;
 }
diff --git a/src/JeMengage/Alert/Provider/ElectionAlertProvider.php b/src/JeMengage/Alert/Provider/ElectionAlertProvider.php
@@ -16,20 +16,22 @@ public function __construct(
     ) {
     }
 
-    public function getAlert(Adherent $adherent): ?Alert
+    public function getAlerts(Adherent $adherent): array
     {
         $designations = $this->electionManager->findActiveDesignations(
             $adherent,
             [DesignationTypeEnum::LOCAL_POLL, DesignationTypeEnum::CONSULTATION, DesignationTypeEnum::VOTE],
         );
 
         if (!$designations) {
-            return null;
+            return [];
         }
 
+        $alerts = [];
+
         foreach ($designations as $designation) {
             if ($designation->alertTitle && $designation->alertDescription) {
-                return new Alert(
+                $alerts[] = new Alert(
                     'Consultation / Élection',
                     $designation->alertTitle,
                     $designation->alertDescription,
@@ -39,6 +41,6 @@ public function getAlert(Adherent $adherent): ?Alert
             }
         }
 
-        return null;
+        return $alerts;
     }
 }