Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept JSON-RPC requests without a params field #3090

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jan 30, 2023

Fix #3080

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      +46825 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::h51e05694fc74eea8
      -42137 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::h7d11981beb5d80d8
        +152 ┊ <serde_json::ser::Compound<W,F> as serde::ser::SerializeStruct>::serialize_field::hcd7c0ce45da9b2c7
         -79 ┊ smoldot::json_rpc::parse::_::<impl serde::ser::Serialize for smoldot::json_rpc::parse::SerdeCall>::serialize::h1e4878f39c6734c6
         +60 ┊ smoldot::json_rpc::parse::build_call::hc73ae00d5571c2d9
         -51 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_value_seed::h755a5dac75dd24f4
         +34 ┊ smoldot::json_rpc::parse::parse_call::hf04df0813880bd39
         +26 ┊ core::ptr::drop_in_place<core::option::Option<core::result::Result<alloc::vec::Vec<&serde_json::raw::RawValue>,serde_json::error::Error>>>::h7faf34a76144760f
         -13 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::h9a08479ee9894006
       +5024 ┊ Σ [9 Total Rows]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow requests with omitted params field
1 participant