Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change grandpa name and use fork_id #2116

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

change grandpa name and use fork_id #2116

wants to merge 7 commits into from

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Mar 3, 2022

Closes #1955

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      +12078 ┊ smoldot::network::service::ChainNetwork<TNow>::next_event::{{closure}}::h877dd552964b598a
      -12074 ┊ smoldot::network::service::ChainNetwork<TNow>::next_event::{{closure}}::he4aaa26d26cbbfb2
       +3317 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha64375b3b3c4e14d
       -3002 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h41591dc67185c0e1
       +2708 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h114db7f02d9b915c
       -2708 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h7565515636f3a322
       +1112 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::h19328b813cd574c4
       -1112 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::h7ac93205b1c5e81b
       -1040 ┊ core::ptr::drop_in_place<futures_util::future::future::remote_handle::Remote<core::future::from_generator::GenFuture<smoldot_light_base::Client<alloc::vec::Vec<futures_util::abortable::AbortHandle>,smoldot_light_wasm::platform::Platform>::add_chain<alloc::vec::into_iter::IntoIter<smoldot_light_base::ChainId>>::{{closure}}>>>::h01436fb15d4efab8
       +1040 ┊ core::ptr::drop_in_place<futures_util::future::future::remote_handle::Remote<core::future::from_generator::GenFuture<smoldot_light_base::Client<alloc::vec::Vec<futures_util::abortable::AbortHandle>,smoldot_light_wasm::platform::Platform>::add_chain<alloc::vec::into_iter::IntoIter<smoldot_light_base::ChainId>>::{{closure}}>>>::h878f88dfc1039b0e
        +962 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::h98a38bc4aaaaaffa
        -796 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot::network::service::ChainNetwork<smoldot_light_wasm::Instant>::next_event::{{closure}}>>::h57f9d84e5b0c0ec0
        +796 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot::network::service::ChainNetwork<smoldot_light_wasm::Instant>::next_event::{{closure}}>>::hf98df8adc2d3976e
        -769 ┊ <core::iter::adapters::chain::Chain<A,B> as core::iter::traits::iterator::Iterator>::next::h991f5942f368cb69
        +769 ┊ <core::iter::adapters::chain::Chain<A,B> as core::iter::traits::iterator::Iterator>::next::hb65289f858700a07
        +711 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h32e8a3e723313dc3
        -711 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h5d4096b660bf0047
        -662 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::h3095cc94be7e23cf
        +417 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h298540077a92bd74
        -417 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h3fafaffd2b1e08d9
        +782 ┊ ... and 210 more.
       +1646 ┊ Σ [230 Total Rows]

@melekes melekes marked this pull request as ready for review March 3, 2022 12:57
@melekes melekes self-assigned this Mar 3, 2022
melekes
melekes commented Mar 3, 2022
View reviewed changes
src/network/service.rs Outdated Show resolved Hide resolved
@tomaka
Copy link
Contributor

tomaka commented Mar 3, 2022

The PR looks good, but because of paritytech/substrate#10969 we might have to wait for another version of Polkadot to be deployed 😬

@melekes melekes added the blocked Can't work on this issue because it is blocked on something out of our control label Mar 3, 2022
@tomaka
Copy link
Contributor

tomaka commented Mar 7, 2022

(needs a CHANGELOG update too)

@tomaka
Copy link
Contributor

tomaka commented Mar 22, 2022

Polkadot v0.9.18 has just been released, but let's wait a week or two for everyone to upgrade.

@tomaka
Copy link
Contributor

tomaka commented May 5, 2022 •
edited
Loading

This can go in, but preferably after #2264.

@tomaka tomaka mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaka tomaka tomaka left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@melekes melekes

Labels
blocked Can't work on this issue because it is blocked on something out of our control
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport protocol name changes and forkId
2 participants
@melekes @tomaka